gundeck: Fix parsing errors for SNS ARN for VOIP Tokens#4040
Merged
gundeck: Fix parsing errors for SNS ARN for VOIP Tokens#4040
Conversation
This reverts commit 232a882.
This will allow writing tests which want more control over the push tokens
zebot
added
the
ok-to-test
elland
force-pushed
the
gundeck-arn-parsing-bug
branch
from
fa79942 to
5b0b280
Compare
elland
force-pushed
the
gundeck-arn-parsing-bug
branch
from
89967fd to
879fd23
Compare
akshaymankar
commented
May 8, 2024
akshaymankar
commented
May 8, 2024
elland
approved these changes
May 8, 2024
echoes-hq
bot
added
the
echoes: unplanned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-9021
This also includes returning a specific error when a client attempts to register a VOIP token, as to avoid any accidental inserts.
Checklist
changelog.d